Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spec refresh #801

Merged
merged 2 commits into from
Aug 17, 2021
Merged

fix: spec refresh #801

merged 2 commits into from
Aug 17, 2021

Conversation

jkaster
Copy link
Contributor

@jkaster jkaster commented Aug 16, 2021

We changes spec fetching to async which made yarn refresh fail

@github-actions
Copy link
Contributor

Codegen Tests

  1 files    6 suites   25s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit 8fd7e22.

joeldodge79
joeldodge79 previously approved these changes Aug 16, 2021
Copy link
Contributor

@joeldodge79 joeldodge79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy fix, but question about commented-out code

packages/sdk-codegen-scripts/src/convert.spec.ts Outdated Show resolved Hide resolved
packages/sdk-codegen-scripts/scripts/utils.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Codegen Tests

  1 files    6 suites   26s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit e758300.

@jkaster jkaster merged commit a10245a into main Aug 17, 2021
@jkaster jkaster deleted the jk/fix_spec_refresh branch August 17, 2021 15:51
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants